Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add events #182

Merged
merged 24 commits into from
May 15, 2023
Merged

feat: add events #182

merged 24 commits into from
May 15, 2023

Conversation

toddbaert
Copy link
Member

@toddbaert toddbaert commented Apr 25, 2023

Adds events discussed in DRAFT client PR, and OFEPs.

Be sure to review specification.json for the net changes.

Most of this is implemented in the web-sdk already. Some conforming (demo) providers can be found in the playground:

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
specification.json Outdated Show resolved Hide resolved
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
specification.json Outdated Show resolved Hide resolved
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm convince on the completeness of this addition. Left one more concern about client shutdown [1] , but the rest looks good. Thank you @toddbaert for taking time on explaining core concepts and clearing doubts

[1] - #182 (comment)

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@toddbaert toddbaert requested a review from beeme1mr May 12, 2023 17:49
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@toddbaert toddbaert merged commit bf9e45b into main May 15, 2023
@toddbaert toddbaert deleted the feat/events branch May 15, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants